Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752633AbdFQQRH (ORCPT ); Sat, 17 Jun 2017 12:17:07 -0400 Received: from ale.deltatee.com ([207.54.116.67]:37037 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751962AbdFQQRF (ORCPT ); Sat, 17 Jun 2017 12:17:05 -0400 To: Greg Kroah-Hartman References: <20170615203729.9009-1-logang@deltatee.com> <20170615203729.9009-3-logang@deltatee.com> <20170617051145.GD6040@kroah.com> Cc: linux-ntb@googlegroups.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Jon Mason , Dave Jiang , Allen Hubbe , Bjorn Helgaas , Kurt Schwemmer , Stephen Bates From: Logan Gunthorpe Message-ID: <04e01458-e57b-a328-d4ff-c1fbb8664bb1@deltatee.com> Date: Sat, 17 Jun 2017 10:16:53 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170617051145.GD6040@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 68.147.191.165 X-SA-Exim-Rcpt-To: sbates@raithlin.com, kurt.schwemmer@microsemi.com, bhelgaas@google.com, Allen.Hubbe@emc.com, dave.jiang@intel.com, jdmason@kudzu.us, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-ntb@googlegroups.com, gregkh@linuxfoundation.org X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [RFC PATCH 02/13] switchtec: export class symbol for use in upper layer driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 422 Lines: 14 On 16/06/17 11:11 PM, Greg Kroah-Hartman wrote: > EXPORT_SYMBOL_GPL()? > > And do you really have to move from a dynamic class to a static one? I > know it will work just the same, but I hate seeing static structures > that have reference counts on them :) I'll change both for v1. I didn't really need a static one. I just saw an example of some other user of class_interface which and it seemed appropriate. Logan