Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752647AbdFQVIR (ORCPT ); Sat, 17 Jun 2017 17:08:17 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:45415 "EHLO hera.aquilenet.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752448AbdFQVIQ (ORCPT ); Sat, 17 Jun 2017 17:08:16 -0400 Date: Sat, 17 Jun 2017 23:08:12 +0200 From: Samuel Thibault To: Okash Khawaja Cc: Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org, Alan Cox , speakup@linux-speakup.org, devel@driverdev.osuosl.org Subject: Re: tty: define tty_open_by_driver when CONFIG_TTY is not defined Message-ID: <20170617210812.rhpbip7iamid5fmo@var.youpi.perso.aquilenet.fr> Mail-Followup-To: Samuel Thibault , Okash Khawaja , Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org, Alan Cox , speakup@linux-speakup.org, devel@driverdev.osuosl.org References: <20170617094641.GA12427@sanghar> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170617094641.GA12427@sanghar> Organization: I am not organized User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 864 Lines: 26 Okash Khawaja, on sam. 17 juin 2017 10:46:41 +0100, wrote: > This patch adds definition of tty_open_by_driver when CONFIG_TTY is not > defined. This was supposed to have been included in commit > 12e84c71b7d4ee38d51377fd494ac748ee4e6912 ("tty: export > tty_open_by_driver"). The patch follows convention for other such > functions and returns NULL. > > Signed-off-by: Okash Khawaja > > --- > include/linux/tty.h | 3 +++ > 1 file changed, 3 insertions(+) > > --- a/include/linux/tty.h > +++ b/include/linux/tty.h > @@ -422,6 +422,9 @@ static inline int __init tty_init(void) > { return 0; } > static inline const char *tty_name(const struct tty_struct *tty) > { return "(none)"; } > +static struct tty_struct *tty_open_by_driver(dev_t device, struct inode *inode, > + struct file *filp) > +{ return NULL; } Add inline Samuel