Date: Sun, 18 Jun 2017 10:37:02 +0200
From: Christoph Hellwig <hch@lst.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm@lists.01.org, Mike Snitzer <snitzer@redhat.com>,
        Toshi Kani <toshi.kani@hpe.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, dm-devel@redhat.com,
        viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH v3 02/14] dm: add ->copy_from_iter() dax operation
        support
Message-ID: <20170618083702.GB26456@lst.de>
References: <149703982465.20620.14881139332926778446.stgit@dwillia2-desk3.amr.corp.intel.com> <149703983692.20620.3787021839815275819.stgit@dwillia2-desk3.amr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <149703983692.20620.3787021839815275819.stgit@dwillia2-desk3.amr.corp.intel.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 465
Lines: 14

> +size_t dax_copy_from_iter(struct dax_device *dax_dev, pgoff_t pgoff, void *addr,
> +		size_t bytes, struct iov_iter *i)
> +{
> +	if (!dax_alive(dax_dev))
> +		return 0;
> +
> +	if (!dax_dev->ops->copy_from_iter)
> +		return copy_from_iter(addr, bytes, i);
> +	return dax_dev->ops->copy_from_iter(dax_dev, pgoff, addr, bytes, i);
> +}
> +EXPORT_SYMBOL_GPL(dax_copy_from_iter);

Can you remove the fallbacks after this series so that we have
a clean abstraction?