Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753488AbdFROIQ (ORCPT ); Sun, 18 Jun 2017 10:08:16 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:36760 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753321AbdFROFG (ORCPT ); Sun, 18 Jun 2017 10:05:06 -0400 Date: Sun, 18 Jun 2017 09:04:49 -0500 From: Rob Herring To: Arun Parameswaran Cc: Richard Cochran , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH v1 1/2] dt-binding: ptp: add bindings document for dte based ptp clock Message-ID: <20170618140449.aek7vag22i5lnbhl@rob-hp-laptop> References: <1497299161-6458-1-git-send-email-arun.parameswaran@broadcom.com> <1497299161-6458-2-git-send-email-arun.parameswaran@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1497299161-6458-2-git-send-email-arun.parameswaran@broadcom.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1176 Lines: 41 On Mon, Jun 12, 2017 at 01:26:00PM -0700, Arun Parameswaran wrote: > Add device tree binding documentation for the Broadcom DTE > PTP clock driver. > > Signed-off-by: Arun Parameswaran > --- > Documentation/devicetree/bindings/ptp/brcm,ptp-dte.txt | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > create mode 100644 Documentation/devicetree/bindings/ptp/brcm,ptp-dte.txt > > diff --git a/Documentation/devicetree/bindings/ptp/brcm,ptp-dte.txt b/Documentation/devicetree/bindings/ptp/brcm,ptp-dte.txt > new file mode 100644 > index 0000000..07590bc > --- /dev/null > +++ b/Documentation/devicetree/bindings/ptp/brcm,ptp-dte.txt > @@ -0,0 +1,13 @@ > +* Broadcom Digital Timing Engine(DTE) based PTP clock driver Bindings describe h/w, not drivers. > + > +Required properties: > +- compatible: should be "brcm,ptp-dte" Looks too generic. You need SoC specific compatible strings. > +- reg: address and length of the DTE block's NCO registers > + > +Example: > + > +ptp_dte: ptp_dte@180af650 { Don't use '_' in node names. > + compatible = "brcm,ptp-dte"; > + reg = <0x180af650 0x10>; > + status = "okay"; > +}; > -- > 1.9.1 >