Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753196AbdFROxP (ORCPT ); Sun, 18 Jun 2017 10:53:15 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:54515 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752925AbdFROxN (ORCPT ); Sun, 18 Jun 2017 10:53:13 -0400 Date: Sun, 18 Jun 2017 16:53:05 +0200 From: Andrew Lunn To: Salil Mehta Cc: davem@davemloft.net, yisen.zhuang@huawei.com, huangdaode@hisilicon.com, lipeng321@huawei.com, mehta.salil.lnk@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com Subject: Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework Message-ID: <20170618145305.GA4025@lunn.ch> References: <20170613231035.494020-1-salil.mehta@huawei.com> <20170613231035.494020-3-salil.mehta@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170613231035.494020-3-salil.mehta@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 676 Lines: 17 On Wed, Jun 14, 2017 at 12:10:29AM +0100, Salil Mehta wrote: > This patch adds the support of the HNAE3 (Hisilicon Network > Acceleration Engine 3) framework support to the HNS3 driver. > > Framework facilitates clients like ENET(HNS3 Ethernet Driver), RoCE > and user-space Ethernet drivers (like ODP etc.) to register with HNAE3 > devices and their associated operations. checkpatch throws out one warning in this file CHECK: Comparison to NULL could be written "pos" #3508: FILE: drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.h:572: + for (pos = (head).ring; pos != NULL; pos = pos->next) This one seems valid. Not all checkpatch warnings are. Andrew