Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753058AbdFRSqr (ORCPT ); Sun, 18 Jun 2017 14:46:47 -0400 Received: from mx.redlab-i.ru ([195.16.34.155]:38528 "EHLO mail.redlab-i.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750999AbdFRSqo (ORCPT ); Sun, 18 Jun 2017 14:46:44 -0400 X-Greylist: delayed 528 seconds by postgrey-1.27 at vger.kernel.org; Sun, 18 Jun 2017 14:46:44 EDT X-Spam-ASN: Date: Sun, 18 Jun 2017 21:37:48 +0300 From: Alexander Gerasiov To: Andy Shevchenko Cc: Sudip Mukherjee , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] parport_serial: Add support for WCH CH382L PCI-E single parallel port card. Message-ID: <20170618213748.28e312c6@brick.gerasiov.net> In-Reply-To: References: <1497704579-29982-1-git-send-email-sudipm.mukherjee@gmail.com> Organization: REDLAB-I LLC X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1531 Lines: 48 Hello Andy, While preparing the update I suddenly found, that parport_serial.c is not the right place for this card. Since there is no serial ports on the board, it would be better to put it into parport_pc.c So I'll resubmit the patch right after I get access to the hardware to check, that I did it the right way. On Sat, 17 Jun 2017 16:45:49 +0300 Andy Shevchenko wrote: > On Sat, Jun 17, 2017 at 4:02 PM, Sudip Mukherjee > wrote: > > From: Alexander Gerasiov > > > > WCH CH382L is a PCI-E adapter with 1 parallel port. It is similair > > to CH382 but serial ports are not soldered on board. Detected as > > Serial controller: Device 1c00:3050 (rev 10) (prog-if 05 [16850]) > > > wch_ch382_2s1p, > > + wch_ch382_0s1p, > > > /* wch_ch382_2s1p*/ { 1, { { 2, -1}, } }, > > + /* wch_ch382_0s1p*/ { 1, { { 2, -1}, } }, > > > { 0x1c00, 0x3250, 0x1c00, 0x3250, 0, 0, wch_ch382_2s1p}, > > + { 0x1c00, 0x3050, 0x1c00, 0x3050, 0, 0, wch_ch382_0s1p}, > > Just a nit, wouldn't be better to preserve alphanumerical sorting? > (Exchange lines in above pairs) > > > + [wch_ch382_0s1p] = { > ... > > [sunix_2s1p] = { > > Similar here, though it's not visible in the patch. > -- Best regards, Alexander Gerasiov Contacts: e-mail: gq@cs.msu.su Homepage: http://gerasiov.net Skype: gerasiov PGP fingerprint: 04B5 9D90 DF7C C2AB CD49 BAEA CA87 E9E8 2AAC 33F1