Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753020AbdFRTyv (ORCPT <rfc822;w@1wt.eu>);
        Sun, 18 Jun 2017 15:54:51 -0400
Received: from mail-qk0-f196.google.com ([209.85.220.196]:32890 "EHLO
        mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752898AbdFRTyt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 18 Jun 2017 15:54:49 -0400
MIME-Version: 1.0
In-Reply-To: <20170618172206.GA393@sanghar>
References: <20170618085825.601359240@gmail.com> <20170618093536.021961426@gmail.com>
 <CAHp75Vfg=ahXP1tGQnzgRRjHczhHA36YT9aDLP6rvwk_hoew1A@mail.gmail.com> <20170618172206.GA393@sanghar>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Sun, 18 Jun 2017 22:54:48 +0300
Message-ID: <CAHp75VeSjCB8CSS_RqKMGB0+zqRZbQqtajS-ebhQv4HKA-V4JA@mail.gmail.com>
Subject: Re: [patch v2 2/3] staging: speakup: check and convert dev name or
 ser to dev_t
To: Okash Khawaja <okash.khawaja@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>,
        Samuel Thibault <samuel.thibault@ens-lyon.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        William Hubbs <w.d.hubbs@gmail.com>,
        Chris Brannon <chris@the-brannons.com>, Kirk Reiser <kirk@reisers.ca>,
        speakup@linux-speakup.org, devel@driverdev.osuosl.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1652
Lines: 49

On Sun, Jun 18, 2017 at 8:22 PM, Okash Khawaja <okash.khawaja@gmail.com> wrote:
> On Sun, Jun 18, 2017 at 04:35:21PM +0300, Andy Shevchenko wrote:

>> > +       if (ser < 0 || ser > (255 - 64)) {
>>
>> > +                pr_err("speakup: Invalid ser param. \
>> > +                               Must be between 0 and 191 inclusive.\n");
>>
>> Just make it one line.
> Is it okay if it becomes larger than 80 chars?

Yes. Even checkpatch will not complain in this case.

>> > +                               pr_err("speakup: lp* is only supported on:");
>>
>> > +                               for (i = 0; i < ARRAY_SIZE(lp_supported); i++)
>> > +                                       pr_cont(" %s", lp_supported[i]);
>> > +                               pr_cont("\n");
>>
>> pr_cont() is not the best idea, though I think it will be rare cases
>> when it might be broken in pieces.

> Hmm... I would like to keep it if it doesn't incur an overhead. It also
> indicates to the reader that this all part of same output line. Let me
> know what you think.

For better user experience you need something like a temporary buffer
and one pr_err(); line at the end.
But as I said here is quite a chance that no one will see this message
broken apart.

>> > --- a/drivers/staging/speakup/spk_types.h
>> > +++ b/drivers/staging/speakup/spk_types.h
>> > @@ -169,6 +169,7 @@ struct spk_synth {
>> >         int jiffies;
>> >         int full;
>> >         int ser;
>>
>> > +       char *dev_name;
>>
>> const ?
> This becomes the target of module_param in following patch. It complains
> when set to const.

Fair enough.

-- 
With Best Regards,
Andy Shevchenko