Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752992AbdFRVHZ (ORCPT ); Sun, 18 Jun 2017 17:07:25 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:33661 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752569AbdFRVHW (ORCPT ); Sun, 18 Jun 2017 17:07:22 -0400 Date: Sun, 18 Jun 2017 22:06:59 +0100 From: Sudip Mukherjee To: Alexander Gerasiov Cc: Andy Shevchenko , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] parport_serial: Add support for WCH CH382L PCI-E single parallel port card. Message-ID: <20170618210659.GA3785@sudip-laptop> References: <1497704579-29982-1-git-send-email-sudipm.mukherjee@gmail.com> <20170618213748.28e312c6@brick.gerasiov.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170618213748.28e312c6@brick.gerasiov.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 563 Lines: 16 On Sun, Jun 18, 2017 at 09:37:48PM +0300, Alexander Gerasiov wrote: > Hello Andy, > > While preparing the update I suddenly found, that parport_serial.c is > not the right place for this card. Since there is no serial ports on > the board, it would be better to put it into parport_pc.c Yes, that will be better. Thanks. I should have pointed that out but I was confused as I saw MOSCHIP 9900, which is parallel only, in that file also. But now digging into the past I found the reason for that. So, yes, your change should be in parport_pc.c -- Regards Sudip