Message-ID: <1497832670.8495.33.camel@perches.com>
Subject: Re: [patch v2 2/3] staging: speakup: check and convert dev name or
 ser to dev_t
From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
        Okash Khawaja <okash.khawaja@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>,
        Samuel Thibault <samuel.thibault@ens-lyon.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        William Hubbs <w.d.hubbs@gmail.com>,
        Chris Brannon <chris@the-brannons.com>, Kirk Reiser <kirk@reisers.ca>,
        speakup@linux-speakup.org, devel@driverdev.osuosl.org
Date: Sun, 18 Jun 2017 17:37:50 -0700
In-Reply-To: <CAHp75VeSjCB8CSS_RqKMGB0+zqRZbQqtajS-ebhQv4HKA-V4JA@mail.gmail.com>
References: <20170618085825.601359240@gmail.com>
         <20170618093536.021961426@gmail.com>
         <CAHp75Vfg=ahXP1tGQnzgRRjHczhHA36YT9aDLP6rvwk_hoew1A@mail.gmail.com>
         <20170618172206.GA393@sanghar>
         <CAHp75VeSjCB8CSS_RqKMGB0+zqRZbQqtajS-ebhQv4HKA-V4JA@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 769
Lines: 18

On Sun, 2017-06-18 at 22:54 +0300, Andy Shevchenko wrote:
> On Sun, Jun 18, 2017 at 8:22 PM, Okash Khawaja <okash.khawaja@gmail.com> wrote:
> > On Sun, Jun 18, 2017 at 04:35:21PM +0300, Andy Shevchenko wrote:
> > > > +       if (ser < 0 || ser > (255 - 64)) {
> > > > +                pr_err("speakup: Invalid ser param. \
> > > > +                               Must be between 0 and 191 inclusive.\n");
> > > 
> > > Just make it one line.
> > 
> > Is it okay if it becomes larger than 80 chars?
> 
> Yes. Even checkpatch will not complain in this case.

And even if it didn't, as written it's a defect
because line continuations don't act like
string concatenations.  You've added a space
before the line continuation \ and a bunch of
whitespace before the word Must