Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753762AbdFSF1i (ORCPT ); Mon, 19 Jun 2017 01:27:38 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:59582 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752389AbdFSF1e (ORCPT ); Mon, 19 Jun 2017 01:27:34 -0400 Date: Mon, 19 Jun 2017 13:27:08 +0800 From: Herbert Xu To: Corentin Labbe Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request Message-ID: <20170619052707.GA13180@gondor.apana.org.au> References: <20170606134417.18850-1-clabbe.montjoie@gmail.com> <20170606134417.18850-3-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170606134417.18850-3-clabbe.montjoie@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 687 Lines: 17 On Tue, Jun 06, 2017 at 03:44:17PM +0200, Corentin Labbe wrote: > The crypto engine could actually only enqueue hash and ablkcipher request. > This patch permit it to enqueue skcipher requets by adding all necessary > functions. > The only problem is that ablkcipher and skcipher id are the same, so > only one cipher type is usable on the same crypto engine. > > Signed-off-by: Corentin Labbe I think this should be done as part of the skcipher conversion rather than as a standalone patch. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt