Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753394AbdFSGGf (ORCPT ); Mon, 19 Jun 2017 02:06:35 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:58587 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053AbdFSGGd (ORCPT ); Mon, 19 Jun 2017 02:06:33 -0400 Date: Mon, 19 Jun 2017 08:06:29 +0200 From: Oleksij Rempel To: Stefan Wahren Cc: Oleksij Rempel , devicetree@vger.kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mark Rutland , Maxime Ripard , Rob Herring , Shawn Guo , Srinivas Kandagatla Subject: Re: [PATCH v5 1/3] nvmem: dt: document SNVS LPGPR binding Message-ID: <20170619060629.du3qmihhkkyym44h@pengutronix.de> References: <20170609125730.25502-1-o.rempel@pengutronix.de> <20170609125730.25502-2-o.rempel@pengutronix.de> <8e50ff3d-d1f0-2795-5dc9-302979ca9694@i2se.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8e50ff3d-d1f0-2795-5dc9-302979ca9694@i2se.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:01:15 up 8 days, 22:11, 11 users, load average: 0.33, 0.13, 0.04 User-Agent: Mutt/1.6.2-neo (2016-06-11) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2140 Lines: 54 On Fri, Jun 09, 2017 at 04:59:00PM +0200, Stefan Wahren wrote: Hi Stefan, > Hi Oleksij, > > Am 09.06.2017 um 14:57 schrieb Oleksij Rempel: > > Documentation bindings for the Low Power General Purpose Register > > available on i.MX6 SoCs in the Secure Non-Volatile Storage. > > > > Signed-off-by: Oleksij Rempel > > --- > > .../devicetree/bindings/nvmem/snvs-lpgpr.txt | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt > > > > diff --git a/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt b/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt > > new file mode 100644 > > index 000000000000..21910fb3159f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.txt > > @@ -0,0 +1,19 @@ > > +Device tree bindings for Low Power General Purpose Register found in i.MX6Q/D > > +Secure Non-Volatile Storage. > > + > > +This DT node should be represented as a sub-node of a "syscon", > > +"simple-mfd" node. > > + > > +Required properties: > > +- compatible: should be: > > + "fsl,imx6q-snvs-lpgpr" for Freescale i.MX6Q/D/DL/S > > + > > +Example: > > +snvs: snvs@020cc000 { > > + compatible = "fsl,sec-v4.0-mon", "syscon", "simple-mfd"; > > + reg = <0x020cc000 0x4000>; > > + > > + snvs_lpgpr: snvs-lpgpr { > > + compatible = "fsl,imx6q-snvs-lpgpr"; > > according to the reference manual at least the clock "lp_ipg_clk_s" is > required for register R/W access. > So it should be added to the binding and enabled by the driver. Hm... Non of current SNVS drives use, set or defines *_ipg_clk_s. I can't find in the docs how can I control this clocks. lp_ipg_clk_s and hp_ipg_clk_s depend on ipg_clk_root, which seems to be not gated. So, it is always on. Or do I miss something. -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |