Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753414AbdFSGoE convert rfc822-to-8bit (ORCPT ); Mon, 19 Jun 2017 02:44:04 -0400 Received: from mail.ginzinger.com ([31.193.165.229]:46977 "EHLO mail.ginzinger.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751024AbdFSGoC (ORCPT ); Mon, 19 Jun 2017 02:44:02 -0400 From: =?iso-8859-1?Q?Sch=F6fegger_Stefan?= To: Fabio Estevam CC: Bjorn Helgaas , "linux-pci@vger.kernel.org" , Richard Zhu , "Arnd Bergmann" , open list , "Kishon Vijay Abraham I" , Jingoo Han , "Bjorn Helgaas" , "moderated list:PCI DRIVER FOR IMX6" , Lucas Stach Subject: Re: [PATCH v2 1/1] PCI: imx6: Add pcie compliance test option Thread-Topic: [PATCH v2 1/1] PCI: imx6: Add pcie compliance test option Thread-Index: AQHS34JNOUvPfo4UA0OvE2IoSGw1A6IhzH4AgABi24CAAIp1gIABCpiAgADfG4CABwrOAA== Date: Mon, 19 Jun 2017 06:43:58 +0000 Message-ID: <1552752.riIkOpKaxW@en-pc05> References: <1472121518-9340-1-git-send-email-stefan.schoefegger@ginzinger.com> <1923573.HjpiSnITgW@en-pc05> In-Reply-To: Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.2.1.54] Content-Type: text/plain; charset="iso-8859-1" Content-ID: <1536121F65F1A54DBF6DC7DA548B546C@ginzinger.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1116 Lines: 29 On Wednesday, June 14, 2017 4:11:29 PM CEST Fabio Estevam wrote: > On Wed, Jun 14, 2017 at 2:52 AM, Sch?fegger Stefan > > wrote: > > device). The bitrate and de-emphasis must be switched. The driver (without > > this patches) does not allow to switch to gen2 because it falls back to > > gen1. It is impossible to generate the gen2 test pattern. > > If you pass 'fsl,max-link-speed = <2>;' in your device tree, then it > will allow gen2. > > From Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt: > > "- fsl,max-link-speed: Specify PCI gen for link capability. Must be '2' for > gen2, otherwise will default to gen1. Note that the IMX6 LVDS clock > outputs do not meet gen2 jitter requirements and thus for gen2 capability a > gen2 compliant clock generator should be used and configured." > > Wouldn't this solve the problem? No, it only sets the maximum allowed link speed but it is forced to gen1 before. During compliance test there is no real link established and there is no link speed negotiation, the phy is in a special compliance test state. Stefan