Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753627AbdFSI15 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 19 Jun 2017 04:27:57 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:26057 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752487AbdFSI14 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 19 Jun 2017 04:27:56 -0400
Date: Mon, 19 Jun 2017 11:27:22 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Okash Khawaja <okash.khawaja@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>,
        Samuel Thibault <samuel.thibault@ens-lyon.org>,
        linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
        Kirk Reiser <kirk@reisers.ca>, speakup@linux-speakup.org,
        Chris Brannon <chris@the-brannons.com>
Subject: Re: [patch v2 2/3] staging: speakup: check and convert dev name or
 ser to dev_t
Message-ID: <20170619082722.2mr6leuimqtyiots@mwanda>
References: <20170618085825.601359240@gmail.com>
 <20170618093536.021961426@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170618093536.021961426@gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
X-Source-IP: userv0022.oracle.com [156.151.31.74]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 437
Lines: 15

On Sun, Jun 18, 2017 at 09:58:27AM +0100, Okash Khawaja wrote:
> +int ser_to_dev(int ser, dev_t *dev_no)
> +{
> +	if (ser < 0 || ser > (255 - 64)) {
> +                pr_err("speakup: Invalid ser param. \
> +				Must be between 0 and 191 inclusive.\n");


I pointed out that all these strings are wrong in the first version of
the patch.  You're going to end up with a whole bunch of tabs in your
dmesg output.

regards,
dan carpenter