Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753770AbdFSIkR (ORCPT ); Mon, 19 Jun 2017 04:40:17 -0400 Received: from mail-wr0-f182.google.com ([209.85.128.182]:34530 "EHLO mail-wr0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752386AbdFSIkP (ORCPT ); Mon, 19 Jun 2017 04:40:15 -0400 Subject: Re: [PATCH v5 3/4] ARM64: dts: meson-gx: use stable UART bindings with correct gate clock To: Kevin Hilman References: <1497428957-19942-1-git-send-email-narmstrong@baylibre.com> <1497428957-19942-4-git-send-email-narmstrong@baylibre.com> Cc: gregkh@linuxfoundation.org, Helmut Klein , linux-serial@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org From: Neil Armstrong Organization: Baylibre Message-ID: Date: Mon, 19 Jun 2017 10:40:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1627 Lines: 45 On 06/16/2017 10:57 PM, Kevin Hilman wrote: > Neil Armstrong writes: > >> From: Helmut Klein >> >> This patch switches to the stable UART bindings but also add the correct >> gate clock to the non-AO UART nodes for GXBB and GXL SoCs. >> >> Acked-by: Jerome Brunet >> Signed-off-by: Helmut Klein >> Signed-off-by: Neil Armstrong >> --- >> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 12 +++++------- >> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 25 +++++++++++++++++++++++++ >> arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 25 +++++++++++++++++++++++++ >> 3 files changed, 55 insertions(+), 7 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi >> index 603491d..86a4018 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi >> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi >> @@ -225,7 +225,7 @@ >> }; >> >> uart_A: serial@84c0 { >> - compatible = "amlogic,meson-uart"; >> + compatible = "amlogic,meson-gx-uart"; > > IMO, we should keep both compatibles (the more specific one first.) > That would allow new DTs to continue to run on older kernels. > > It would also allow this DT change to be completely independent of the > driver changes. Otherwise, if I merge this before the driver change are > merged, we'll have a bunch of boards with no more serial console output. > > Kevin > Hi Kevin, Sure, no problem with that. I'll push an update when the bindings + tty fixes are merged somewhere. Neil