Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753929AbdFSJUY (ORCPT ); Mon, 19 Jun 2017 05:20:24 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:60536 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753682AbdFSJUW (ORCPT ); Mon, 19 Jun 2017 05:20:22 -0400 Subject: Re: [PATCH v3] PCI: dwc: dra7xx: Fix compilation warning. To: Arvind Yadav , Bjorn Helgaas References: <20170615204951.GD12735@bhelgaas-glaptop.roam.corp.google.com> <16817169-9f2e-5406-f61c-b2d683559815@gmail.com> CC: , , , From: Kishon Vijay Abraham I Message-ID: <277fbefd-cbd8-47ee-2707-937c2b014b89@ti.com> Date: Mon, 19 Jun 2017 14:49:25 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <16817169-9f2e-5406-f61c-b2d683559815@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1615 Lines: 41 Hi, On Friday 16 June 2017 01:48 PM, Arvind Yadav wrote: > Hi Kishon/Bjorn, > > What is correct Setting for these two PCIECTRL_DRA7XX_CONF_IRQSTATUS_MSI and > PCIECTRL_DRA7XX_CONF_IRQSTATUS_MAIN register. > > Value of register After change: > register[PCIECTRL_DRA7XX_CONF_IRQSTATUS_MSI] = LEG_EP_INTERRUPTS | MSI > = 0x1f > register[PCIECTRL_DRA7XX_CONF_IRQSTATUS_MAIN] = INTERRUPTS > = 0x1fff > Is this correct? That's correct. That patch as such is correct but the changelog and subject has to be fixed. You can use something like below for subject and changelog. "PCI: dwc: dra7xx: Fix incorrect usage of IRQSTATUS_* registers commit 47ff3de911 ("PCI: dra7xx: Add TI DRA7xx PCIe driver") in order to clear MSI and MAIN interrupts requests wrote '0' to PCIECTRL_TI_CONF_IRQSTATUS_MSI and PCIECTRL_TI_CONF_IRQSTATUS_MAIN registers. However the TRM has mentioned to write '1' to clear pending event in these two registers. Fix it here. This also helps to get rid of the following compilation warning: drivers/pci/dwc/pci-dra7xx.c: In function ‘dra7xx_pcie_enable_msi_interrupts’: drivers/pci/dwc/pci-dra7xx.c:177:7: warning: large integer implicitly truncated to unsigned type [-Woverflow] ~LEG_EP_INTERRUPTS & ~MSI); ^ drivers/pci/dwc/pci-dra7xx.c: In function ‘dra7xx_pcie_enable_wrapper_interrupts’: drivers/pci/dwc/pci-dra7xx.c:187:7: warning: large integer implicitly truncated to unsigned type [-Woverflow] ~INTERRUPTS);" For the patch itself Acked-by: Kishon Vijay Abraham I Thanks Kishon