Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753735AbdFSJcB (ORCPT ); Mon, 19 Jun 2017 05:32:01 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:34268 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090AbdFSJb7 (ORCPT ); Mon, 19 Jun 2017 05:31:59 -0400 Subject: Re: [PATCH v3] PCI: dwc: dra7xx: Fix compilation warning. To: Kishon Vijay Abraham I , Bjorn Helgaas References: <20170615204951.GD12735@bhelgaas-glaptop.roam.corp.google.com> <16817169-9f2e-5406-f61c-b2d683559815@gmail.com> <277fbefd-cbd8-47ee-2707-937c2b014b89@ti.com> Cc: bhelgaas@google.com, linux-omap@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org From: Arvind Yadav Message-ID: Date: Mon, 19 Jun 2017 15:01:26 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <277fbefd-cbd8-47ee-2707-937c2b014b89@ti.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1834 Lines: 48 Hi, Thanks for you suggestion. I will update change log and re-submit. Regards ~arvind On Monday 19 June 2017 02:49 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Friday 16 June 2017 01:48 PM, Arvind Yadav wrote: >> Hi Kishon/Bjorn, >> >> What is correct Setting for these two PCIECTRL_DRA7XX_CONF_IRQSTATUS_MSI and >> PCIECTRL_DRA7XX_CONF_IRQSTATUS_MAIN register. >> >> Value of register After change: >> register[PCIECTRL_DRA7XX_CONF_IRQSTATUS_MSI] = LEG_EP_INTERRUPTS | MSI >> = 0x1f >> register[PCIECTRL_DRA7XX_CONF_IRQSTATUS_MAIN] = INTERRUPTS >> = 0x1fff >> Is this correct? > That's correct. That patch as such is correct but the changelog and subject has > to be fixed. You can use something like below for subject and changelog. > > "PCI: dwc: dra7xx: Fix incorrect usage of IRQSTATUS_* registers > > commit 47ff3de911 ("PCI: dra7xx: Add TI DRA7xx PCIe driver") in order to clear > MSI and MAIN interrupts requests wrote '0' to PCIECTRL_TI_CONF_IRQSTATUS_MSI > and PCIECTRL_TI_CONF_IRQSTATUS_MAIN registers. However the TRM has mentioned to > write '1' to clear pending event in these two registers. Fix it here. > > This also helps to get rid of the following compilation warning: > drivers/pci/dwc/pci-dra7xx.c: In function ‘dra7xx_pcie_enable_msi_interrupts’: > drivers/pci/dwc/pci-dra7xx.c:177:7: warning: large integer implicitly truncated > to unsigned type [-Woverflow] > ~LEG_EP_INTERRUPTS & ~MSI); > ^ > drivers/pci/dwc/pci-dra7xx.c: In function ‘dra7xx_pcie_enable_wrapper_interrupts’: > drivers/pci/dwc/pci-dra7xx.c:187:7: warning: large integer implicitly truncated > to unsigned type [-Woverflow] > ~INTERRUPTS);" > > For the patch itself > Acked-by: Kishon Vijay Abraham I > > Thanks > Kishon