Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753895AbdFSJf1 (ORCPT ); Mon, 19 Jun 2017 05:35:27 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:32034 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752389AbdFSJf0 (ORCPT ); Mon, 19 Jun 2017 05:35:26 -0400 Date: Mon, 19 Jun 2017 12:35:08 +0300 From: Dan Carpenter To: Derek Robson Cc: forest@alittletooquiet.net, gregkh@linuxfoundation.org, rvarsha016@gmail.com, sucha.cpe@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3] staging: vt6655 - style fix Message-ID: <20170619093507.xnuosshoiyejkgow@mwanda> References: <20170617025648.14027-1-robsonde@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170617025648.14027-1-robsonde@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 496 Lines: 16 On Sat, Jun 17, 2017 at 02:56:48PM +1200, Derek Robson wrote: > Fix checkpatch.pl warnings of the form "function definition argument > 'foo' should also have an identifier name" in header files. > > Signed-off-by: Derek Robson > > V1 and V2 had vague subject line > --- The subject is *still* too vague. Say something like: [PATCH v4] Staging: vt6655 - add parameter names Also the "V1 and V2 had vague subject line" has to go after the --- line instead of before it.