Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753995AbdFSLEs (ORCPT ); Mon, 19 Jun 2017 07:04:48 -0400 Received: from ozlabs.org ([103.22.144.67]:34367 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753775AbdFSLEr (ORCPT ); Mon, 19 Jun 2017 07:04:47 -0400 From: Michael Ellerman To: Ram Pai , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: benh@kernel.crashing.org, paulus@samba.org, khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com, dave.hansen@intel.com, hbabu@us.ibm.com, linuxram@us.ibm.com Subject: Re: [RFC v2 12/12]selftest: Updated protection key selftest In-Reply-To: <1497671564-20030-13-git-send-email-linuxram@us.ibm.com> References: <1497671564-20030-1-git-send-email-linuxram@us.ibm.com> <1497671564-20030-13-git-send-email-linuxram@us.ibm.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Mon, 19 Jun 2017 21:04:44 +1000 Message-ID: <87efugutkj.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 747 Lines: 18 Ram Pai writes: > Added test support for PowerPC implementation off protection keys. > > Signed-off-by: Ram Pai > --- > tools/testing/selftests/vm/Makefile | 1 + > tools/testing/selftests/vm/pkey-helpers.h | 365 +++++++ > tools/testing/selftests/vm/protection_keys.c | 1451 +++++++++++++++++++++++++ > tools/testing/selftests/x86/Makefile | 2 +- > tools/testing/selftests/x86/pkey-helpers.h | 219 ---- > tools/testing/selftests/x86/protection_keys.c | 1395 ------------------------ Please split the move and the addition of the powerpc code into two separate patches (move first). That way we can actually see what you're doing to add powerpc support. cheers