Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753960AbdFSLGR (ORCPT ); Mon, 19 Jun 2017 07:06:17 -0400 Received: from ozlabs.org ([103.22.144.67]:60083 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753580AbdFSLGQ (ORCPT ); Mon, 19 Jun 2017 07:06:16 -0400 From: Michael Ellerman To: Ram Pai , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: benh@kernel.crashing.org, paulus@samba.org, khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com, dave.hansen@intel.com, hbabu@us.ibm.com, linuxram@us.ibm.com Subject: Re: [RFC v2 10/12] powerpc: Read AMR only if pkey-violation caused the exception. In-Reply-To: <1497671564-20030-11-git-send-email-linuxram@us.ibm.com> References: <1497671564-20030-1-git-send-email-linuxram@us.ibm.com> <1497671564-20030-11-git-send-email-linuxram@us.ibm.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Mon, 19 Jun 2017 21:06:13 +1000 Message-ID: <87bmpkuti2.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 929 Lines: 27 Ram Pai writes: > Signed-off-by: Ram Pai > --- > arch/powerpc/kernel/exceptions-64s.S | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S > index 8db9ef8..a4de1b4 100644 > --- a/arch/powerpc/kernel/exceptions-64s.S > +++ b/arch/powerpc/kernel/exceptions-64s.S > @@ -493,13 +493,15 @@ EXC_COMMON_BEGIN(data_access_common) > ld r12,_MSR(r1) > ld r3,PACA_EXGEN+EX_DAR(r13) > lwz r4,PACA_EXGEN+EX_DSISR(r13) > + std r3,_DAR(r1) > + std r4,_DSISR(r1) > #ifdef CONFIG_PPC64_MEMORY_PROTECTION_KEYS > + andis. r0,r4,DSISR_KEYFAULT@h /* save AMR only if its a key fault */ > + beq+ 1f This seems to be incremental on top of one of your other patches. But I don't see why, can you please just squash this into whatever patch adds this code in the first place. cheers