Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751144AbdFSNwD convert rfc822-to-8bit (ORCPT ); Mon, 19 Jun 2017 09:52:03 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:58674 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751099AbdFSNwB (ORCPT ); Mon, 19 Jun 2017 09:52:01 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Sumit Semwal , shuah@kernel.org, linux-kselftest@vger.kernel.org From: Chris Wilson In-Reply-To: <1497879872-11137-1-git-send-email-sumit.semwal@linaro.org> Cc: lukas@wunner.de, linux-kernel@vger.kernel.org, daniel.vetter@ffwll.ch, joonas.lahtinen@linux.intel.com, "Sumit Semwal" References: <1497879872-11137-1-git-send-email-sumit.semwal@linaro.org> Message-ID: <149788031144.14237.2576196706318669393@mail.alporthouse.com> User-Agent: alot/0.3.6 Subject: Re: [PATCH 2/2] selftests: lib: prime_numbers: update presence check Date: Mon, 19 Jun 2017 14:51:51 +0100 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 584 Lines: 13 Quoting Sumit Semwal (2017-06-19 14:44:32) > The test for prime numbers doesn't differentiate between missing > prime_numbers.ko and failure in prime_numbers.ko. > > Update it to check for presence of the file itself to skip, therefore > correctly exercising the test failure case. modprobe -r shouldn't be executing the module? But you still need to unload the module before you can load it with the selftest module parameters. If you can't unload the module due to an earlier failure, you cannot discern whether or not the module itself is at fault, so still want to SKIP. -Chris