MIME-Version: 1.0
In-Reply-To: <149788031144.14237.2576196706318669393@mail.alporthouse.com>
References: <1497879872-11137-1-git-send-email-sumit.semwal@linaro.org> <149788031144.14237.2576196706318669393@mail.alporthouse.com>
From: Sumit Semwal <sumit.semwal@linaro.org>
Date: Mon, 19 Jun 2017 20:16:20 +0530
Message-ID: <CAO_48GEvapHpTBm2xSR+nzDhTJaKP3JZ5me58XghKB5K+0d5cg@mail.gmail.com>
Subject: Re: [PATCH 2/2] selftests: lib: prime_numbers: update presence check
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org, lukas@wunner.de,
        LKML <linux-kernel@vger.kernel.org>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1064
Lines: 30

Hi Chris,

On 19 June 2017 at 19:21, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Sumit Semwal (2017-06-19 14:44:32)
>> The test for prime numbers doesn't differentiate between missing
>> prime_numbers.ko and failure in prime_numbers.ko.
>>
>> Update it to check for presence of the file itself to skip, therefore
>> correctly exercising the test failure case.
>
> modprobe -r shouldn't be executing the module? But you still need to
> unload the module before you can load it with the selftest module
> parameters. If you can't unload the module due to an earlier failure,
> you cannot discern whether or not the module itself is at fault, so
> still want to SKIP.

My bad here: I missed the '-r' in the first modprobe.

I am wondering if 'modprobe -q -n' won't suffice, as it is a dry-run
only, but will still search for the module? Unless of course, there's
something specific about '-q -r' that seems better still?

Shuah,
Could you please disregard this patch, and the other patch I sent:
will send out a new version soon.

> -Chris

Best,
Sumit.