Date: Wed, 11 Jun 2003 15:31:07 -0700 (PDT)
From: Patrick Mochel <mochel@osdl.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: sysfs: Initialization order and system devices
In-Reply-To: <1055369924.4071.19.camel@localhost.localdomain>
Message-ID: <Pine.LNX.4.44.0306111529260.11379-100000@cherise>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1529
Lines: 44


On 11 Jun 2003, Jeremy Fitzhardinge wrote:

> With the current system device changes (I picked them up in 2.5.70-mm8),
> the system device class assumes that all system device drivers are
> registered before any system devices are registered.
> 
> Unfortunately, this is often not the case.  CPU devices are registered
> very early, but cpufreq registers drivers for them; since cpufreq
> drivers can be loaded as modules, they clearly can't be registered
> before the device is.
> 
> This patch keeps a list of all registered devices hanging off the system
> device class.  When a new driver is registered, it calls the driver's
> add() function with all existing devices.
> 
> Conversely, when a driver is unregistered, it calls the driver's
> remove() function for all existing devices so the driver can clean up.

D'oh. I meant to add this piece for precisely this reason. Thanks, though 
there is one thing: 

+
+       /* If devices of this class already exist, tell the driver */
+       if (drv->add) {
+               struct sys_device *dev;
+               list_for_each_entry(dev, &cls->devices, entry)
+                       drv->add(dev);
+       }
+

in sysdev_driver_register(). You must check that cls is not NULL. I've 
fixed it up and applied it.

Thanks,


	-pat

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/