From: "Kershner, David A" <David.Kershner@unisys.com>
To: Derek Robson <robsonde@gmail.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "Sell, Timothy C" <Timothy.Sell@unisys.com>,
        "Binder, David Anthony" <David.Binder@unisys.com>,
        "Wadgaonkar, Sameer Laxmikant" <Sameer.Wadgaonkar@unisys.com>,
        "marcos.souza.org@gmail.com" <marcos.souza.org@gmail.com>
CC: *S-Par-Maintainer <SParMaintainer@unisys.com>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V2] staging: unisys: visorhba - style fix
Thread-Topic: [PATCH V2] staging: unisys: visorhba - style fix
Thread-Index: AQHS5xemh5vI3rfHMEObHKYCzF0gpqIsUmNg
Date: Mon, 19 Jun 2017 15:28:19 +0000
Message-ID: <CY4PR07MB3176E806363185B742FC40BCF0C40@CY4PR07MB3176.namprd07.prod.outlook.com>
References: <20170617031255.14575-1-robsonde@gmail.com>
In-Reply-To: <20170617031255.14575-1-robsonde@gmail.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jun 2017 15:28:19.3972
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8d894c2b-238f-490b-8dd1-d93898c5bf83
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3127
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5JFSZxm015345
Content-Length: 1574
Lines: 44


> -----Original Message-----
> From: Derek Robson [mailto:robsonde@gmail.com]
> Sent: Friday, June 16, 2017 11:13 PM
> To: Kershner, David A <David.Kershner@unisys.com>;
> gregkh@linuxfoundation.org; Sell, Timothy C <Timothy.Sell@unisys.com>;
> Binder, David Anthony <David.Binder@unisys.com>; Wadgaonkar, Sameer
> Laxmikant <Sameer.Wadgaonkar@unisys.com>;
> marcos.souza.org@gmail.com; robsonde@gmail.com
> Cc: *S-Par-Maintainer <SParMaintainer@unisys.com>;
> devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org
> Subject: [PATCH V2] staging: unisys: visorhba - style fix
> 
> Fixed style of permissions to octal.
> Found using checkpatch
> 
> Signed-off-by: Derek Robson <robsonde@gmail.com>

I applied it and tested it. Though when I applied it, the V1 comment was included in the patch commit. 


> 
> V1 has vauge subject
> ---
>  drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
> b/drivers/staging/unisys/visorhba/visorhba_main.c
> index 2fd31c9762c6..a6e7a6bbc428 100644
> --- a/drivers/staging/unisys/visorhba/visorhba_main.c
> +++ b/drivers/staging/unisys/visorhba/visorhba_main.c
> @@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev)
>  		goto err_scsi_remove_host;
>  	}
>  	devdata->debugfs_info =
> -		debugfs_create_file("info", S_IRUSR | S_IRGRP,
> +		debugfs_create_file("info", 0440,
>  				    devdata->debugfs_dir, devdata,
>  				    &info_debugfs_fops);
>  	if (!devdata->debugfs_info) {
> --
> 2.13.0