Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753398AbdFSP3p (ORCPT <rfc822;w@1wt.eu>);
        Mon, 19 Jun 2017 11:29:45 -0400
Received: from vmicros1.altlinux.org ([194.107.17.57]:52714 "EHLO
        vmicros1.altlinux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752964AbdFSP3m (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 19 Jun 2017 11:29:42 -0400
Date: Mon, 19 Jun 2017 18:29:18 +0300
From: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        David Lin <dtwlin@google.com>, Steven Rostedt <rostedt@goodmis.org>,
        Michal Marek <mmarek@suse.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Sasha Levin <alexander.levin@verizon.com>,
        "Anton V. Boyarshinov" <boyarsh@altlinux.org>,
        "Dmitry V. Levin" <ldv@altlinux.org>
Subject: Re: [PATCH 4.9 031/108] jump label: pass kbuild_cflags when checking
 for asm goto support
Message-ID: <20170619152918.GC10396@glebfm.cloud.tilaa.com>
References: <20170615175337.190782107@linuxfoundation.org>
 <20170615175338.665696624@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170615175338.665696624@linuxfoundation.org>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1852
Lines: 51

On Thu, Jun 15, 2017 at 07:52:37PM +0200, Greg Kroah-Hartman wrote:
> 4.9-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: David Lin <dtwlin@google.com>
> 
> 
> [ Upstream commit 35f860f9ba6aac56cc38e8b18916d833a83f1157 ]

This commit introduced a regression which was fixed in
7292ae3d5a18fb922be496e6bb687647193569b4.
Backport the fix too, please.

As long as there is no gcc-plugin support in 4.4, 35f860f9ba6a does not
break anything there, AFAICS.

> Some versions of ARM GCC compiler such as Android toolchain throws in a
> '-fpic' flag by default.  This causes the gcc-goto check script to fail
> although some config would have '-fno-pic' flag in the KBUILD_CFLAGS.
> 
> This patch passes the KBUILD_CFLAGS to the check script so that the
> script does not rely on the default config from different compilers.
> 
> Link: http://lkml.kernel.org/r/20170120234329.78868-1-dtwlin@google.com
> Signed-off-by: David Lin <dtwlin@google.com>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>
> Cc: Michal Marek <mmarek@suse.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/Makefile
> +++ b/Makefile
> @@ -797,7 +797,7 @@ KBUILD_CFLAGS   += $(call cc-option,-Wer
>  KBUILD_ARFLAGS := $(call ar-option,D)
>  
>  # check for 'asm goto'
> -ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC)), y)
> +ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC) $(KBUILD_CFLAGS)), y)
>  	KBUILD_CFLAGS += -DCC_HAVE_ASM_GOTO
>  	KBUILD_AFLAGS += -DCC_HAVE_ASM_GOTO
>  endif
> 

-- 
glebfm