Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754341AbdFSPfV (ORCPT ); Mon, 19 Jun 2017 11:35:21 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:47545 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754020AbdFSPfT (ORCPT ); Mon, 19 Jun 2017 11:35:19 -0400 X-ME-Sender: X-Sasl-enc: pZeA1N+NuNaPHiEBW8hW0c7Y4XWjPZJy4CnpjPpvBb2D 1497886507 Date: Mon, 19 Jun 2017 23:24:29 +0800 From: Greg Kroah-Hartman To: Evgeniy Polyalkov Cc: Johannes =?iso-8859-1?Q?P=F6hlmann?= , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V1] one wire ds1wm patch Message-ID: <20170619152429.GA22977@kroah.com> References: <6a03463f-7e93-8ee7-d56f-aaed1e2befba@izt-labs.de> <2576141497884112@web5j.yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2576141497884112@web5j.yandex.ru> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1251 Lines: 37 On Mon, Jun 19, 2017 at 05:55:12PM +0300, Evgeniy Polyalkov wrote: > Hi > > 19.06.2017, 14:38, "Johannes P?hlmann" : > > To make the ds1wm driver work on a powerpc architecture (big endian, 32bit) > > with a register offset multiplier of 4 i had to make some changes to > > > > ??????????drivers/w1/masters/ds1wm.c > > and include/linux/mfd/ds1wm.h. > > > > I grouped theses into 4 patches of falling priority. > > > > [PATCH 1/4] fix and simplify register access > > [PATCH 2/4] Add level interrupt modes (maybe no longer needed in newer > > kernels) > > [PATCH 3/4] Silence interrupts on HW before claiming the interrupt > > [PATCH 4/4] optional: add messages to make incorporation in mfd drivers > > easier > > Patches look good, thank you. No they do not, they need to be sent in the correct format, with the correct signed-off-by, and all of the needed information... > Greg, please pull them into your tree, is it ok to be sent as attachment? Not at all. > Acked-by: Evgeniy Polyakov Johannes, please fix up and resend and add Evgeniy's acked-by to the patchs and I will be glad to take them. Please read Documentation/SubmittingPatches for the correct format to use. thanks, greg k-h