Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752336AbdFSQKD (ORCPT ); Mon, 19 Jun 2017 12:10:03 -0400 Received: from mx2.suse.de ([195.135.220.15]:50855 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751434AbdFSQKB (ORCPT ); Mon, 19 Jun 2017 12:10:01 -0400 Date: Mon, 19 Jun 2017 18:09:58 +0200 (CEST) From: Miroslav Benes To: Petr Mladek cc: Joe Lawrence , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Josh Poimboeuf , Jessica Yu , Jiri Kosina Subject: Re: [PATCH 1/3] livepatch: introduce shadow variable API In-Reply-To: <20170614125913.GC15013@pathway.suse.cz> Message-ID: References: <1496341526-19061-1-git-send-email-joe.lawrence@redhat.com> <1496341526-19061-2-git-send-email-joe.lawrence@redhat.com> <20170614125913.GC15013@pathway.suse.cz> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 514 Lines: 20 > > +struct klp_shadow { > > + struct hlist_node node; > > + struct rcu_head rcu_head; > > + void *obj; > > + char *var; > > + void *data; > > I would make the meaning more obvious. What about renaming? > > var -> key or id > data -> shadow_obj or new_obj But var is not a key to a hash table. obj is. Renaming obj to key would be misleading in my opinion, because it IS a pointer to an object. And data is ok too, as far as I'm concerned. Just saying. But yes, I'd welcome a description too. Miroslav