Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751858AbdFSQYK (ORCPT ); Mon, 19 Jun 2017 12:24:10 -0400 Received: from mail-ua0-f171.google.com ([209.85.217.171]:32852 "EHLO mail-ua0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbdFSQYH (ORCPT ); Mon, 19 Jun 2017 12:24:07 -0400 MIME-Version: 1.0 In-Reply-To: <201706191819.37016@pali> References: <201706191807.42574@pali> <074e9d5668864a81b255df178ed28814@ausx13mpc120.AMER.DELL.COM> <201706191819.37016@pali> From: Andy Lutomirski Date: Mon, 19 Jun 2017 09:23:45 -0700 Message-ID: Subject: Re: [PATCH v2] platform/x86: wmi-bmof: New driver to expose embedded Binary WMI MOF metadata To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Mario.Limonciello@dell.com, Andrew Lutomirski , platform-driver-x86@vger.kernel.org, Andy Shevchenko , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Linux ACPI Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5JGOIeP025807 Content-Length: 3230 Lines: 70 On Mon, Jun 19, 2017 at 9:19 AM, Pali Rohár wrote: > On Monday 19 June 2017 18:13:13 Mario.Limonciello@dell.com wrote: >> > -----Original Message----- >> > From: Pali Rohár [mailto:pali.rohar@gmail.com] >> > Sent: Monday, June 19, 2017 11:08 AM >> > To: Andy Lutomirski >> > Cc: platform-driver-x86@vger.kernel.org; Andy Shevchenko >> > ; Andy Lutomirski >> > ; Limonciello, Mario >> > ; Rafael Wysocki ; >> > linux-kernel@vger.kernel.org; linux-acpi@vger.kernel.org Subject: >> > Re: [PATCH v2] platform/x86: wmi-bmof: New driver to expose >> > embedded Binary WMI MOF metadata >> > >> > On Tuesday 06 June 2017 05:16:44 Andy Lutomirski wrote: >> > > Many laptops (and maybe servers?) have embedded WMI Binary MOF >> > > metadata. We do not yet have open-source tools for processing the >> > > >> > > data, although one is in the works thanks to Pali: >> > > https://github.com/pali/bmfdec >> > > >> > > There is currently no interface to get the data in the first >> > > place. By exposing it, we facilitate the development of new >> > > tools. >> > > >> > > Signed-off-by: Andy Lutomirski >> > > Cc: Andy Lutomirski >> > > Cc: Mario Limonciello >> > > Cc: Pali Rohár >> > > Cc: linux-kernel@vger.kernel.org >> > > Cc: platform-driver-x86@vger.kernel.org >> > > Cc: linux-acpi@vger.kernel.org >> > > [dvhart: make sysfs mof binary read only, fixup comment block >> > > format] [dvhart: use bmof terminology and dev_err instead of >> > > dev_warn] Acked-by: Rafael J. Wysocki >> > > Signed-off-by: Darren Hart (VMware) >> > > --- >> > > >> > > since-v1: >> > > * address Pali's comments: >> > > * update the cover letter for clarity and accuracy >> > > * update mof->bmof and MOF to Binary MOF throughout the patch >> > > * use dev_err instead of dev_warn in wmi_bmof_probe >> > > >> > > drivers/platform/x86/Kconfig | 12 ++++ >> > > drivers/platform/x86/Makefile | 1 + >> > > drivers/platform/x86/wmi-bmof.c | 125 >> > >> > Another suggestion (unrelated to this patch): For working with >> > ACPI-WMI, this binary MOF buffer is not enough. It is needed also >> > content of _WDG buffer. What about exporting it too via sysfs? >> > Probably not part of of wmi-bmof driver, but wmi driver itself. >> >> I think this depends upon how the userspace access to WMI methods >> gets implemented, no? If userpsace access to WMI methods show up as >> /dev/wmi-$GUID-$INSTANCE and those internally to the kernel map to >> the proper ASL methods for example, what you get from wmi-bmof >> should be enough shouldn't it? > > Ok. Such interface for userspace application could be enough. > > But for debugging purposes or writing new WMI driver it is needed to > have both _WDG + BMOF. With the busification patches applied, all the _WDG data should be available in sysfs in parsed form. I have no particular objection to adding a new sysfs for debugfs file to give the raw binary blob, but I'm not sure it's needed. --Andy