Date: Mon, 19 Jun 2017 18:43:22 +0200 (CEST)
From: Miroslav Benes <mbenes@suse.cz>
To: Joe Lawrence <joe.lawrence@redhat.com>
cc: live-patching@vger.kernel.org, Petr Mladek <pmladek@suse.com>,
        linux-kernel@vger.kernel.org, Josh Poimboeuf <jpoimboe@redhat.com>,
        Jessica Yu <jeyu@redhat.com>, Jiri Kosina <jikos@kernel.org>
Subject: Re: [PATCH 3/3] livepatch: add shadow variable sample program
In-Reply-To: <035502e6-6daf-d7e3-5f34-18723c977dda@redhat.com>
Message-ID: <alpine.LSU.2.20.1706191839060.5419@pobox.suse.cz>
References: <1496341526-19061-1-git-send-email-joe.lawrence@redhat.com> <1496341526-19061-4-git-send-email-joe.lawrence@redhat.com> <20170614142102.GA2583@pathway.suse.cz> <035502e6-6daf-d7e3-5f34-18723c977dda@redhat.com>
User-Agent: Alpine 2.20 (LSU 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 709
Lines: 15


> Good catch.  Let me add a disclaimer here and state that this example is
> definitely contrived as I was trying to minimize its size.  Applying
> shadow variables to a more real life use case would drag in a bunch of
> "changed" function dependencies.  I didn't want to work around those
> with a pile of kallsyms workarounds.  It did lead you to ask an
> interesting question though:

You can always create a completely artificial sample based on a real life 
use case. I mean, you can create a module with functions and data 
structures you need and then patch one of those functions. You control 
everything and you can limit dependencies and kallsyms workarounds (or 
avoid them completely).

Miroslav