Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751882AbdFSR7g (ORCPT ); Mon, 19 Jun 2017 13:59:36 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:44031 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751096AbdFSR7f (ORCPT ); Mon, 19 Jun 2017 13:59:35 -0400 Date: Mon, 19 Jun 2017 10:59:19 -0700 From: Ram Pai To: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, benh@kernel.crashing.org, paulus@samba.org, khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com, dave.hansen@intel.com, hbabu@us.ibm.com Subject: Re: [RFC v2 10/12] powerpc: Read AMR only if pkey-violation caused the exception. Reply-To: Ram Pai References: <1497671564-20030-1-git-send-email-linuxram@us.ibm.com> <1497671564-20030-11-git-send-email-linuxram@us.ibm.com> <87bmpkuti2.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87bmpkuti2.fsf@concordia.ellerman.id.au> User-Agent: Mutt/1.5.20 (2009-12-10) X-TM-AS-GCONF: 00 x-cbid: 17061917-0044-0000-0000-000003557959 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007256; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000214; SDB=6.00877076; UDB=6.00436881; IPR=6.00657218; BA=6.00005431; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015888; XFM=3.00000015; UTC=2017-06-19 17:59:31 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17061917-0045-0000-0000-000007837FEA Message-Id: <20170619175919.GD5845@ram.oc3035372033.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-19_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706190296 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1128 Lines: 31 On Mon, Jun 19, 2017 at 09:06:13PM +1000, Michael Ellerman wrote: > Ram Pai writes: > > > Signed-off-by: Ram Pai > > --- > > arch/powerpc/kernel/exceptions-64s.S | 16 ++++++++++------ > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S > > index 8db9ef8..a4de1b4 100644 > > --- a/arch/powerpc/kernel/exceptions-64s.S > > +++ b/arch/powerpc/kernel/exceptions-64s.S > > @@ -493,13 +493,15 @@ EXC_COMMON_BEGIN(data_access_common) > > ld r12,_MSR(r1) > > ld r3,PACA_EXGEN+EX_DAR(r13) > > lwz r4,PACA_EXGEN+EX_DSISR(r13) > > + std r3,_DAR(r1) > > + std r4,_DSISR(r1) > > #ifdef CONFIG_PPC64_MEMORY_PROTECTION_KEYS > > + andis. r0,r4,DSISR_KEYFAULT@h /* save AMR only if its a key fault */ > > + beq+ 1f > > This seems to be incremental on top of one of your other patches. > > But I don't see why, can you please just squash this into whatever patch > adds this code in the first place. It was an optimization added later. But yes it can be squashed into an earlier patch. RP