Subject: Re: [patch] as-iosched divide by zero fix
From: Robert Love <rml@tech9.net>
To: Andrew Morton <akpm@digeo.com>
Cc: bos@serpentine.com, linux-kernel@vger.kernel.org, piggin@cyberone.com.au
In-Reply-To: <20030611182249.0f1168e4.akpm@digeo.com>
References: <1055369849.1084.4.camel@serpentine.internal.keyresearch.com>
	 <20030611154122.55570de0.akpm@digeo.com> <1055374476.673.1.camel@localhost>
	 <1055377120.665.6.camel@localhost> <20030611172444.76556d5d.akpm@digeo.com>
	 <1055380257.662.8.camel@localhost> <20030611182249.0f1168e4.akpm@digeo.com>
Content-Type: text/plain
Message-Id: <1055381318.662.30.camel@localhost>
Mime-Version: 1.0
Date: 11 Jun 2003 18:28:39 -0700
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 649
Lines: 22

On Wed, 2003-06-11 at 18:22, Andrew Morton wrote:

> hrm, OK.  Still not convinced about `batch'.

batch is only zero if {read,write}_batch_expire are zero. Nick, is that
legal/desirable? Or should we prevent that in the sysfs interface?

> -		if (write_time / batch > 2)
> +		if (write_time > batch * 2)
>
> -		if (batch / write_time > 2)
> +		if (batch > write_time * 2)

Much better! :)

	Robert Love

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/