Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751928AbdFSSFj (ORCPT ); Mon, 19 Jun 2017 14:05:39 -0400 Received: from mail-yw0-f177.google.com ([209.85.161.177]:35719 "EHLO mail-yw0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751771AbdFSSFO (ORCPT ); Mon, 19 Jun 2017 14:05:14 -0400 Date: Mon, 19 Jun 2017 14:05:11 -0400 From: Tejun Heo To: Arvind Yadav Cc: b.zolnierkie@samsung.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ata: sata_rcar: make of_device_ids const. Message-ID: <20170619180511.GD12062@htj.duckdns.org> References: <474047fe3280ca103275247df6aa67288220a9d4.1497614383.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <474047fe3280ca103275247df6aa67288220a9d4.1497614383.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 672 Lines: 21 On Fri, Jun 16, 2017 at 05:32:21PM +0530, Arvind Yadav wrote: > of_device_ids are not supposed to change at runtime. All functions > working with of_device_ids provided by work with const > of_device_ids. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 3946 2296 0 6242 1862 drivers/ata/sata_rcar.o > > File size after constify sata_rcar_match. > text data bss dec hex filename > 5554 696 0 6250 186a drivers/ata/sata_rcar.o > > Signed-off-by: Arvind Yadav Applied to libata/for-4.13. Thanks. -- tejun