Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753697AbdFSS74 (ORCPT ); Mon, 19 Jun 2017 14:59:56 -0400 Received: from www.llwyncelyn.cymru ([82.70.14.225]:48860 "EHLO fuzix.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753779AbdFSSht (ORCPT ); Mon, 19 Jun 2017 14:37:49 -0400 Date: Mon, 19 Jun 2017 19:37:34 +0100 From: Alan Cox To: Sudip Mukherjee Cc: Alexander Gerasiov , Andy Shevchenko , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] parport_serial: Add support for WCH CH382L PCI-E single parallel port card. Message-ID: <20170619193734.08f1697f@alans-desktop> In-Reply-To: <20170618210659.GA3785@sudip-laptop> References: <1497704579-29982-1-git-send-email-sudipm.mukherjee@gmail.com> <20170618213748.28e312c6@brick.gerasiov.net> <20170618210659.GA3785@sudip-laptop> Organization: Intel Corporation X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 692 Lines: 20 On Sun, 18 Jun 2017 22:06:59 +0100 Sudip Mukherjee wrote: > On Sun, Jun 18, 2017 at 09:37:48PM +0300, Alexander Gerasiov wrote: > > Hello Andy, > > > > While preparing the update I suddenly found, that parport_serial.c is > > not the right place for this card. Since there is no serial ports on > > the board, it would be better to put it into parport_pc.c > > Yes, that will be better. Thanks. Are the uarts physically present but the connector unwired, or are they not detectable at all ? If it's the former then can you add a comment in parport_serial.c giving the ID and explaining why it's not present, even if you put the code into parport_pc. Alan