Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753800AbdFSTAG (ORCPT ); Mon, 19 Jun 2017 15:00:06 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:32769 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752650AbdFSTAD (ORCPT ); Mon, 19 Jun 2017 15:00:03 -0400 Date: Mon, 19 Jun 2017 15:00:00 -0400 From: Tejun Heo To: Shaohua Li Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, gregkh@linuxfoundation.org, hch@lst.de, axboe@fb.com, rostedt@goodmis.org, lizefan@huawei.com, Kernel-team@fb.com, Shaohua Li Subject: Re: [PATCH V3 04/12] kernfs: don't set dentry->d_fsdata Message-ID: <20170619190000.GI12062@htj.duckdns.org> References: <1442e3c6160a06186d7071bd594bdff81b0050b8.1497549993.git.shli@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442e3c6160a06186d7071bd594bdff81b0050b8.1497549993.git.shli@fb.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 602 Lines: 18 On Thu, Jun 15, 2017 at 11:17:12AM -0700, Shaohua Li wrote: > From: Shaohua Li > > When working on adding exportfs operations in kernfs, I found it's hard > to initialize dentry->d_fsdata in the exportfs operations. Looks there > is no way to do it without race condition. Look at the kernfs code > closely, there is no point to set dentry->d_fsdata. inode->i_private > already points to kernfs_node, and we can get inode from a dentry. So > this patch just delete the d_fsdata usage. > > Signed-off-by: Shaohua Li Acked-by: Tejun Heo Thanks. -- tejun