Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753520AbdFSTJx (ORCPT ); Mon, 19 Jun 2017 15:09:53 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:35228 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750946AbdFSTJu (ORCPT ); Mon, 19 Jun 2017 15:09:50 -0400 Date: Mon, 19 Jun 2017 15:09:43 -0400 From: Tejun Heo To: Shaohua Li Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, gregkh@linuxfoundation.org, hch@lst.de, axboe@fb.com, rostedt@goodmis.org, lizefan@huawei.com, Kernel-team@fb.com, Shaohua Li Subject: Re: [PATCH V3 09/12] block: always attach cgroup info into bio Message-ID: <20170619190943.GL12062@htj.duckdns.org> References: <1f9bf3d57d5fe644f433844354c9af1aedb8442a.1497549993.git.shli@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1f9bf3d57d5fe644f433844354c9af1aedb8442a.1497549993.git.shli@fb.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 481 Lines: 17 On Thu, Jun 15, 2017 at 11:17:17AM -0700, Shaohua Li wrote: > From: Shaohua Li > > blkcg_bio_issue_check() already gets blkcg for a BIO. > bio_associate_blkcg() uses a percpu refcounter, so it's a very cheap > operation. There is no point we don't attach the cgroup info into bio at > blkcg_bio_issue_check. This also makes blktrace outputs correct cgroup > info. > > Signed-off-by: Shaohua Li Acked-by: Tejun Heo Thanks. -- tejun