Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753163AbdFSTWB (ORCPT ); Mon, 19 Jun 2017 15:22:01 -0400 Received: from b.ns.miles-group.at ([95.130.255.144]:44723 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751763AbdFSTV7 (ORCPT ); Mon, 19 Jun 2017 15:21:59 -0400 Subject: Re: [PATCH for v4.9 LTS 13/86] ubifs: allow encryption ioctls in compat mode To: Eric Biggers , "Levin, Alexander (Sasha Levin)" Cc: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20170617222420.19316-1-alexander.levin@verizon.com> <20170617222420.19316-13-alexander.levin@verizon.com> <20170619170236.GA143304@google.com> From: Richard Weinberger Message-ID: <9259cf25-f27b-5199-b9c4-647c17112ff0@nod.at> Date: Mon, 19 Jun 2017 21:21:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170619170236.GA143304@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1345 Lines: 39 Am 19.06.2017 um 19:02 schrieb Eric Biggers: > On Sat, Jun 17, 2017 at 10:24:31PM +0000, Levin, Alexander (Sasha Levin) wrote: >> From: Eric Biggers >> >> [ Upstream commit a75467d910135905de60b3af3f11b3693625781e ] >> >> The ubifs encryption ioctls did not work when called by a 32-bit program >> on a 64-bit kernel. Since 'struct fscrypt_policy' is not affected by >> the word size, ubifs just needs to allow these ioctls through, like what >> ext4 and f2fs do. >> >> Signed-off-by: Eric Biggers >> Signed-off-by: Richard Weinberger >> Signed-off-by: Sasha Levin >> --- >> fs/ubifs/ioctl.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/fs/ubifs/ioctl.c b/fs/ubifs/ioctl.c >> index 3c7b29de0ca7..49d6c0f89c50 100644 >> --- a/fs/ubifs/ioctl.c >> +++ b/fs/ubifs/ioctl.c >> @@ -197,6 +197,9 @@ long ubifs_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg) >> case FS_IOC32_SETFLAGS: >> cmd = FS_IOC_SETFLAGS; >> break; >> + case FS_IOC_SET_ENCRYPTION_POLICY: >> + case FS_IOC_GET_ENCRYPTION_POLICY: >> + break; >> default: >> return -ENOIOCTLCMD; >> } > > UBIFS encryption was merged in 4.10, so this isn't needed in 4.9. Yep. I wonder why this patch made it into the stable queue? Thanks, //richard