Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752630AbdFSVBE (ORCPT ); Mon, 19 Jun 2017 17:01:04 -0400 Received: from mail-pf0-f169.google.com ([209.85.192.169]:36514 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752548AbdFSVBB (ORCPT ); Mon, 19 Jun 2017 17:01:01 -0400 Date: Mon, 19 Jun 2017 14:00:55 -0700 From: Bjorn Andersson To: Stanimir Varbanov Cc: Olof Johansson , Andy Gross , Arnd Bergmann , "linux-kernel@vger.kernel.org" , linux-arm-msm , Stephen Boyd Subject: Re: [PATCH v2] firmware: qcom_scm: Fix to allow COMPILE_TEST-ing Message-ID: <20170619210055.GF17640@tuxbook> References: <1496935418-14142-1-git-send-email-stanimir.varbanov@linaro.org> <9e0b85dd-3621-cd8c-7ec6-67e319cab071@linaro.org> <58ebc743-953b-e2f4-08ca-fa1642f27a5b@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58ebc743-953b-e2f4-08ca-fa1642f27a5b@linaro.org> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1791 Lines: 59 On Mon 19 Jun 05:19 PDT 2017, Stanimir Varbanov wrote: > Hi Olof, > > On 06/19/2017 02:25 PM, Stanimir Varbanov wrote: > > Hi Olof, > > > > On 06/19/2017 08:35 AM, Olof Johansson wrote: > >> Hi, > >> > >> On Thu, Jun 8, 2017 at 8:23 AM, Stanimir Varbanov [..] > >> > >> It probably makes more sense to stub the driver->scm interface than > >> the internal scm interface if what you're looking for is driver > >> compile_test coverage. > > > > Actually, this is the state of qcom_scm if we don't apply the this > > patch, and it didn't help. Thinking more on that it looks like that > > adding COMPILE_TEST in 'config QCOM_SCM' is controversial. > > > > Arnd, Andy any ideas how to proceed. If this patch is not get merged > > (and I/we cannot find better solution) the video driver for qualcomm > > platforms will be rejected for 4.13. > > > > Currently the dependences are: > > VIDEO_QCOM_VENUS selects QCOM_MDT_LOADER > QCOM_MDT_LOADER selects QCOM_SCM > > And I came to this, > > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > index 9fca977ef18d..b8657c561eae 100644 > --- a/drivers/soc/qcom/Kconfig > +++ b/drivers/soc/qcom/Kconfig > @@ -12,7 +12,7 @@ config QCOM_GSBI > > config QCOM_MDT_LOADER > tristate > - select QCOM_SCM > + depends on QCOM_SCM || COMPILE_TEST The problem with this is that QCOM_SCM is not user selectable and you can't select MDT_LOADER if you make it depend on QCOM_SCM - as this might not be enabled by the user (if you make it user selectable). The problem that I see changing this is that there's no point in making QCOM_SCM and QCOM_MDT_LOADER user selectable - they don't serve a purpose on their own. PS. Don't you depend on scm functionality directly from the venus driver as well? Regards, Bjorn