Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752316AbdFSVOa (ORCPT ); Mon, 19 Jun 2017 17:14:30 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:47478 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113AbdFSVO2 (ORCPT ); Mon, 19 Jun 2017 17:14:28 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 19 Jun 2017 14:14:26 -0700 From: Sodagudi Prasad To: David Rientjes Cc: mark.rutland@arm.com, will.deacon@arm.com, catalin.marinas@arm.com, mingo@kernel.org, peterz@infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] compiler, clang: Add always_inline attribute to inline In-Reply-To: References: <20170615155440.GC26471@leverpostej> <1497887596-8731-1-git-send-email-psodagud@codeaurora.org> Message-ID: <47bd7df20466d5f7f557ca087b0189cf@codeaurora.org> User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1968 Lines: 60 On 2017-06-19 13:25, David Rientjes wrote: > On Mon, 19 Jun 2017, Prasad Sodagudi wrote: > >> Commit abb2ea7dfd82 ("compiler, clang: suppress warning for unused >> static inline functions") re-defining the 'inline' macro but >> __attribute__((always_inline)) is missing. Some compilers may >> not honor inline hint if always_iniline attribute not there. >> So add always_inline attribute to inline as done by >> compiler-gcc.h file. >> > > IIUC, __attribute__((always_inline)) was only needed for gcc versions < > 4 > and that the inlining decision making is improved in >= 4. To make a > change like this, I would think that we would need to show that clang > is > making suboptimal decisions. I don't think there's a downside to > making > CONFIG_OPTIMIZE_INLINING specific only to gcc. > > If it is shown that __attribute__((always_inline)) is needed for clang > as > well, this should be done as part of compiler-gcc.h to avoid duplicated > code. Hi David, Here is the discussion about this change - https://lkml.org/lkml/2017/6/15/396 Please check mark and will's comments. -Thanks, Prasad > >> Signed-off-by: Prasad Sodagudi >> --- >> include/linux/compiler-clang.h | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/include/linux/compiler-clang.h >> b/include/linux/compiler-clang.h >> index d614c5e..deb65b3 100644 >> --- a/include/linux/compiler-clang.h >> +++ b/include/linux/compiler-clang.h >> @@ -22,4 +22,9 @@ >> * directives. Suppress the warning in clang as well. >> */ >> #undef inline >> +#if !defined(CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING) || \ >> + !defined(CONFIG_OPTIMIZE_INLINING) >> +#define inline inline __attribute__((always_inline)) >> __attribute__((unused)) notrace >> +#else >> #define inline inline __attribute__((unused)) notrace >> +#endif -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, Linux Foundation Collaborative Project