Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752720AbdFTArN (ORCPT ); Mon, 19 Jun 2017 20:47:13 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34816 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751963AbdFTArL (ORCPT ); Mon, 19 Jun 2017 20:47:11 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5A8B960730 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Mon, 19 Jun 2017 17:47:09 -0700 From: Stephen Boyd To: Srinivas Kandagatla Cc: linux-clk@vger.kernel.org, Andy Gross , Michael Turquette , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: gcc-msm8996: Add missing lpass smmu clks Message-ID: <20170620004709.GD20170@codeaurora.org> References: <20170612094137.6821-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170612094137.6821-1-srinivas.kandagatla@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1455 Lines: 48 On 06/12, Srinivas Kandagatla wrote: > This patch adds missing LPASS smmu clks which are required by the audio driver. > > Signed-off-by: Srinivas Kandagatla > --- > drivers/clk/qcom/gcc-msm8996.c | 26 ++++++++++++++++++++++++++ > include/dt-bindings/clock/qcom,gcc-msm8996.h | 2 ++ > 2 files changed, 28 insertions(+) > > diff --git a/drivers/clk/qcom/gcc-msm8996.c b/drivers/clk/qcom/gcc-msm8996.c > index 56e0a295c74e..6290ce551505 100644 > --- a/drivers/clk/qcom/gcc-msm8996.c > +++ b/drivers/clk/qcom/gcc-msm8996.c > @@ -2644,6 +2644,30 @@ static struct clk_fixed_factor ufs_rx_cfg_clk_src = { > }, > }; > > +static struct clk_branch gcc_hlos1_vote_lpass_core_smmu_clk = { > + .halt_reg = 0x7d010, Don't we need .halt_check = BRANCH_HALT_VOTED for these? > + .clkr = { > + .enable_reg = 0x7d010, > + .enable_mask = BIT(0), > + .hw.init = &(struct clk_init_data){ > + .name = "hlos1_vote_lpass_core_smmu_clk", > + .ops = &clk_branch2_ops, > + }, > + }, > +}; > + > +static struct clk_branch gcc_hlos1_vote_lpass_adsp_smmu_clk = { > + .halt_reg = 0x7d014, > + .clkr = { > + .enable_reg = 0x7d014, > + .enable_mask = BIT(0), > + .hw.init = &(struct clk_init_data){ > + .name = "hlos1_vote_lpass_adsp_smmu_clk", > + .ops = &clk_branch2_ops, > + }, > + }, > +}; > + -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project