Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750992AbdFTCWQ (ORCPT ); Mon, 19 Jun 2017 22:22:16 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:60810 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750844AbdFTCWP (ORCPT ); Mon, 19 Jun 2017 22:22:15 -0400 Date: Tue, 20 Jun 2017 09:28:58 +0800 From: Herbert Xu To: Horia =?utf-8?Q?Geant=C4=83?= Cc: David Gstir , Dan Douglass , "davem@davemloft.net" , "richard@sigma-star.at" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC PATCH 1/2] crypto: caam - properly set IV after {en,de}crypt Message-ID: <20170620012858.GA16207@gondor.apana.org.au> References: <20170602122446.2427-1-david@sigma-star.at> <20170602122446.2427-2-david@sigma-star.at> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 449 Lines: 13 On Mon, Jun 19, 2017 at 10:31:27AM +0000, Horia Geantă wrote: > > IIUC, IV update is required only in case of CBC. > Since this callback is used also for CTR, we should avoid the copy: > if ((ctx->cdata.algtype & OP_ALG_AAI_MASK) == OP_ALG_AAI_CBC) ... No it is needed for CTR too. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt