Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752052AbdFTDmo (ORCPT ); Mon, 19 Jun 2017 23:42:44 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:60946 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750925AbdFTDmm (ORCPT ); Mon, 19 Jun 2017 23:42:42 -0400 Date: Tue, 20 Jun 2017 11:42:20 +0800 From: Herbert Xu To: Arvind Yadav Cc: davem@davemloft.net, tglx@linutronix.de, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: n2: make of_device_ids const Message-ID: <20170620034220.GJ17764@gondor.apana.org.au> References: <9ab9e99928c8add9d11779c5f5a267f10f166875.1497527778.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9ab9e99928c8add9d11779c5f5a267f10f166875.1497527778.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 805 Lines: 20 On Thu, Jun 15, 2017 at 05:28:10PM +0530, Arvind Yadav wrote: > of_device_ids are not supposed to change at runtime. All functions > working with of_device_ids provided by work with const > of_device_ids. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 2001 2168 48 4217 1079 drivers/crypto/n2_core.o > > File size after constify dummy_tlb_ops.: > text data bss dec hex filename > 3601 536 48 4185 1059 drivers/crypto/n2_core.o > > Signed-off-by: Arvind Yadav Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt