Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751125AbdFTEri (ORCPT <rfc822;w@1wt.eu>);
        Tue, 20 Jun 2017 00:47:38 -0400
Received: from mail-io0-f174.google.com ([209.85.223.174]:36711 "EHLO
        mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750918AbdFTErY (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 20 Jun 2017 00:47:24 -0400
MIME-Version: 1.0
In-Reply-To: <20170608055655.GB19269@kroah.com>
References: <20170608025831.GA43608@beast> <20170608055655.GB19269@kroah.com>
From: Kees Cook <keescook@chromium.org>
Date: Mon, 19 Jun 2017 21:47:22 -0700
X-Google-Sender-Auth: PI1BPeib9Gqpkj85vzbo56mEaFk
Message-ID: <CAGXu5jJs+sFhmWSWqOjDnyzpSn8fbACLYUw=KBB4w_YfEDVXNA@mail.gmail.com>
Subject: Re: [PATCH v2] refcount: Create unchecked atomic_t implementation
To: Greg KH <gregkh@linuxfoundation.org>, Ingo Molnar <mingo@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Christoph Hellwig <hch@infradead.org>,
        Peter Zijlstra <peterz@infradead.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>, Jann Horn <jannh@google.com>,
        Eric Biggers <ebiggers3@gmail.com>,
        Elena Reshetova <elena.reshetova@intel.com>,
        Hans Liljestrand <ishkamiel@gmail.com>,
        David Windsor <dwindsor@gmail.com>, Ingo Molnar <mingo@redhat.com>,
        Alexey Dobriyan <adobriyan@gmail.com>,
        "Serge E. Hallyn" <serge@hallyn.com>, arozansk@redhat.com,
        Davidlohr Bueso <dave@stgolabs.net>,
        Manfred Spraul <manfred@colorfullife.com>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        James Bottomley <James.Bottomley@hansenpartnership.com>,
        "x86@kernel.org" <x86@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        "David S. Miller" <davem@davemloft.net>,
        Rik van Riel <riel@redhat.com>,
        linux-arch <linux-arch@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 830
Lines: 23

On Wed, Jun 7, 2017 at 10:56 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Wed, Jun 07, 2017 at 07:58:31PM -0700, Kees Cook wrote:
>> Many subsystems will not use refcount_t unless there is a way to build the
>> kernel so that there is no regression in speed compared to atomic_t. This
>> adds CONFIG_REFCOUNT_FULL to enable the full refcount_t implementation
>> which has the validation but is slightly slower. When not enabled,
>> refcount_t uses the basic unchecked atomic_t routines, which results in
>> no code changes compared to just using atomic_t directly.
>>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Ping. tip maintainers, can you please take this patch to unblock the
refcount_t conversions?

Thanks!

-Kees

-- 
Kees Cook
Pixel Security