Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751078AbdFTFBn (ORCPT ); Tue, 20 Jun 2017 01:01:43 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:37471 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750927AbdFTFBl (ORCPT ); Tue, 20 Jun 2017 01:01:41 -0400 Subject: Re: [PATCH v5 3/6] kernel/reboot.c: export pm_power_off_prepare To: Leonard Crestez , Oleksij Rempel References: <20170619050245.2632-1-o.rempel@pengutronix.de> <20170619050245.2632-4-o.rempel@pengutronix.de> <1497872109.5380.10.camel@nxp.com> Cc: Andrew Morton , devicetree@vger.kernel.org, Fabio Estevam , kernel@pengutronix.de, Liam Girdwood , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown , Mark Rutland , Michael Turquette , Rob Herring , Russell King , Shawn Guo , Stephen Boyd From: Oleksij Rempel Message-ID: <5023d338-f845-b8a6-c4a0-d414c75f841c@pengutronix.de> Date: Tue, 20 Jun 2017 07:01:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1497872109.5380.10.camel@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:13da X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1099 Lines: 31 On 19.06.2017 13:35, Leonard Crestez wrote: > On Mon, 2017-06-19 at 07:02 +0200, Oleksij Rempel wrote: >> Export pm_power_off_prepare. It is needed to implement power off on >> Freescale/NXP iMX6 based boards with external power management >> integrated circuit (PMIC). >> >> Signed-off-by: Oleksij Rempel >> --- >> kernel/reboot.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/kernel/reboot.c b/kernel/reboot.c >> index bd30a973fe94..a6903bf772c7 100644 >> --- a/kernel/reboot.c >> +++ b/kernel/reboot.c >> @@ -49,6 +49,7 @@ int reboot_force; >> */ >> >> void (*pm_power_off_prepare)(void); >> +EXPORT_SYMBOL(pm_power_off_prepare); >> > Could you register a reboot notifier in the pfuze driver instead? Right > now the only user of pm_power_off_prepare is ACPI so this alternative > seems less intrusive. hm... in this case i will need to make sure that reboot handler is not executed on reboot. This will make code looks strange. Which is opposite of your comment in other email about strange standby code for power off :) Should i really do this?