Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750985AbdFTG0W (ORCPT ); Tue, 20 Jun 2017 02:26:22 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:45371 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750826AbdFTG0V (ORCPT ); Tue, 20 Jun 2017 02:26:21 -0400 From: Anshuman Khandual Subject: Re: [RFC v2 12/12]selftest: Updated protection key selftest To: Ram Pai , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <1497671564-20030-1-git-send-email-linuxram@us.ibm.com> <1497671564-20030-13-git-send-email-linuxram@us.ibm.com> Cc: dave.hansen@intel.com, paulus@samba.org, aneesh.kumar@linux.vnet.ibm.com Date: Tue, 20 Jun 2017 11:56:04 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1497671564-20030-13-git-send-email-linuxram@us.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable x-cbid: 17062006-0004-0000-0000-0000021ABD37 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17062006-0005-0000-0000-00005DFE4FF6 Message-Id: <126766e1-070c-7072-1bc8-ebdf6e22db43@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-20_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706200117 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 450 Lines: 10 On 06/17/2017 09:22 AM, Ram Pai wrote: > Added test support for PowerPC implementation off protection keys. > > Signed-off-by: Ram Pai First of all, there are a lot of instances where we use *pkru* named functions on power even the real implementations have taken care of doing appropriate things. That looks pretty hacky. We need to change them to generic names first before adding both x86 and powerpc procedures inside it.