Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751126AbdFTGpo (ORCPT ); Tue, 20 Jun 2017 02:45:44 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33780 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750826AbdFTGpm (ORCPT ); Tue, 20 Jun 2017 02:45:42 -0400 Date: Tue, 20 Jun 2017 08:45:39 +0200 From: Corentin Labbe To: Jessica Yu Cc: rusty@rustcorp.com.au, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] kernel/module.c: Invert add_usage_link and del_usage_link functions Message-ID: <20170620064539.GA12930@Red> References: <20170606121740.350-1-clabbe.montjoie@gmail.com> <20170606121740.350-2-clabbe.montjoie@gmail.com> <20170619162622.7hbxm6k53f43nooh@redbean> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170619162622.7hbxm6k53f43nooh@redbean> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 694 Lines: 21 On Mon, Jun 19, 2017 at 06:26:23PM +0200, Jessica Yu wrote: > +++ Corentin Labbe [06/06/17 14:17 +0200]: > >This patch just swap del_usage_link() before add_usage_link(). > > > >Signed-off-by: Corentin Labbe > > Could you combine this with the 2nd patch? By itself this patch > doesn't tell us much. Additionally, could you explain in the changelog > (of the 2nd patch) why they needed to be swapped (i.e., so > del_usage_links() can be called from add_usage_links()). > > Thanks! > > Jessica > I think that its against the rule of atomic/simple patch. Perhaps, the first patch miss some "why I do it" Anyway I will send a new version as you requested Regards