Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751223AbdFTG6t (ORCPT <rfc822;w@1wt.eu>);
        Tue, 20 Jun 2017 02:58:49 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:41446 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751113AbdFTG6s (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 20 Jun 2017 02:58:48 -0400
Date: Tue, 20 Jun 2017 08:58:36 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Dou Liyang <douly.fnst@cn.fujitsu.com>
cc: LKML <linux-kernel@vger.kernel.org>,
        Marc Zyngier <marc.zyngier@arm.com>, Christoph Hellwig <hch@lst.de>,
        Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Michael Ellerman <mpe@ellerman.id.au>, Jens Axboe <axboe@kernel.dk>,
        Keith Busch <keith.busch@intel.com>
Subject: Re: [patch 19/55] genirq: Provide irq_fixup_move_pending()
In-Reply-To: <fe7919b0-726d-6296-d1ca-ad55e5dd77fe@cn.fujitsu.com>
Message-ID: <alpine.DEB.2.20.1706200858070.1869@nanos>
References: <20170619233700.547167146@linutronix.de> <20170619235444.691345468@linutronix.de> <fe7919b0-726d-6296-d1ca-ad55e5dd77fe@cn.fujitsu.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1205
Lines: 37

On Tue, 20 Jun 2017, Dou Liyang wrote:
> At 06/20/2017 07:37 AM, Thomas Gleixner wrote:
> [...]
> > 
> > +/**
> > + * irq_fixup_move_pending - Cleanup irq move pending from a dying CPU
> > + * @desc:		Interrupt descpriptor to clean up
> > + * @force_clear:	If set clear the move pending bit unconditionally.
> > + *			If not set, clear it only when the dying CPU is the
> > + *			last one in the pending mask.
> > + *
> > + * Returns true if the pending bit was set and the pending mask contains an
> > + * online CPU other than the dying CPU.
> > + */
> > +bool irq_fixup_move_pending(struct irq_desc *desc, bool force_clear)
> > +{
> > +	struct irq_data *data = irq_desc_get_irq_data(desc);
> > +
> > +	if (!irqd_is_setaffinity_pending(data))
> > +		return false;
> > +
> > +	/*
> > +	 * The outgoing CPU might be the last online target in a pending
> > +	 * interrupt move. If that's the case clear the pending move bit.
> > +	 */
> > +	if (cpumask_any_and(desc->pending_mask, cpu_online_mask) > nr_cpu_ids)
> > {
> 
> Should we consider the case of "=nr_cpu_ids" here, like:
> 
> cpumask_any_and(desc->pending_mask, cpu_online_mask) >= nr_cpu_ids

Yes, indeed. > is wrong. Good catch!

Thanks,

	tglx