Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751667AbdFTIQu (ORCPT ); Tue, 20 Jun 2017 04:16:50 -0400 Received: from mail-it0-f41.google.com ([209.85.214.41]:38366 "EHLO mail-it0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751136AbdFTIQr (ORCPT ); Tue, 20 Jun 2017 04:16:47 -0400 MIME-Version: 1.0 In-Reply-To: <379d9c7235c36ff524e88a056be45622f23bdea9.1497033197.git.jan.kiszka@siemens.com> References: <379d9c7235c36ff524e88a056be45622f23bdea9.1497033197.git.jan.kiszka@siemens.com> From: Linus Walleij Date: Tue, 20 Jun 2017 10:16:45 +0200 Message-ID: Subject: Re: [PATCH v6 05/10] gpio: exar: Fix reading of directions and values To: Jan Kiszka Cc: Alexandre Courbot , Greg Kroah-Hartman , Linux Kernel Mailing List , "linux-serial@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Sudip Mukherjee , Andy Shevchenko , Sascha Weisenberger Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 487 Lines: 14 On Fri, Jun 9, 2017 at 8:33 PM, Jan Kiszka wrote: > First, the logic for translating a register bit to the return code of > exar_get_direction and exar_get_value were wrong. And second, there was > a flip regarding the register bank in exar_get_direction. > > Signed-off-by: Jan Kiszka > Reviewed-by: Andy Shevchenko > Acked-by: Linus Walleij Patch applied. Yours, Linus Walleij