Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751761AbdFTIjE (ORCPT ); Tue, 20 Jun 2017 04:39:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:37236 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751082AbdFTIjB (ORCPT ); Tue, 20 Jun 2017 04:39:01 -0400 Date: Tue, 20 Jun 2017 10:38:58 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Daniel Stone cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Che-Liang Chiou , Thierry Escande , Benjamin Tissoires Subject: Re: [PATCH] Revert "HID: magicmouse: Set multi-touch keybits for Magic Mouse" In-Reply-To: <20170615123550.20661-1-daniels@collabora.com> Message-ID: References: <20170615123550.20661-1-daniels@collabora.com> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 495 Lines: 17 On Thu, 15 Jun 2017, Daniel Stone wrote: > Setting these bits causes libinput to fail to initialize the device; > setting BTN_TOUCH and BTN_TOOL_FINGER causes it to treat the mouse as a > touchpad, and it then refuses to continue when it discovers ABS_X is not > set. > > This breaks all known Wayland compositors, as well as Xorg when the > libinput driver is being used. > > This reverts commit f4b65b9563216b3e01a5cc844c3ba68901d9b195. Queued for 4.12. Thanks, -- Jiri Kosina SUSE Labs