Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752837AbdFTJL7 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 20 Jun 2017 05:11:59 -0400
Received: from mail-wm0-f43.google.com ([74.125.82.43]:37835 "EHLO
        mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751131AbdFTJLt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 20 Jun 2017 05:11:49 -0400
MIME-Version: 1.0
In-Reply-To: <20170620034222.nykxdbagaqa3rqni@codemonkey.org.uk>
References: <CA+55aFxmLjP10GTyDwgA_2iMtf8U1oqqVDV4ZU=_gvnbSOZVMA@mail.gmail.com>
 <20170620002612.bwjphlk2qz3ynghl@codemonkey.org.uk> <CA+55aFwM8ka+a26QU+qjVCSXraaLW5ksyNxkR+BifFxE9_=E0Q@mail.gmail.com>
 <alpine.LSU.2.11.1706192006330.6396@eggly.anvils> <20170620034222.nykxdbagaqa3rqni@codemonkey.org.uk>
From: Andy Whitcroft <apw@canonical.com>
Date: Tue, 20 Jun 2017 10:11:36 +0100
X-Google-Sender-Auth: nqNl79z86r-Zx8_9EDGA9sMtJm0
Message-ID: <CAAq6er1=oeR9RP2JbwjaOY+F3saUwE7OgWVh-CCVqDuejKCTbw@mail.gmail.com>
Subject: Re: Linux 4.12-rc6
To: Dave Jones <davej@codemonkey.org.uk>, Hugh Dickins <hughd@google.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Oleg Nesterov <oleg@redhat.com>, Michal Hocko <mhocko@suse.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1095
Lines: 28

On Tue, Jun 20, 2017 at 4:42 AM, Dave Jones <davej@codemonkey.org.uk> wrote:

> Almost shutdown, but not quite.  Coincidentally, coverity just finished
> the rc6 run, and barfed this up..  related ?
>
> *** CID 1412907:  Control flow issues  (DEADCODE)
> /include/linux/mm.h: 2243 in vm_end_gap()
> 2237
> 2238     static inline unsigned long vm_end_gap(struct vm_area_struct *vma)
> 2239     {
> 2240            unsigned long vm_end = vma->vm_end;
> 2241
> 2242            if (vma->vm_flags & VM_GROWSUP) {
>>>>     CID 1412907:  Control flow issues  (DEADCODE)
>>>>     Execution cannot reach this statement: "vm_end += stack_guard_gap;".
> 2243                    vm_end += stack_guard_gap;
> 2244                    if (vm_end < vma->vm_end)
> 2245                            vm_end = -PAGE_SIZE;
> 2246            }
> 2247            return vm_end;
> 2248     }

I suspect this is because coverity can tell we do not use VM_GROWSUP
in x86.  I assume it would say the corresponding thing about the
VM_GROWSDOWN code in vm_start_gap() on those architectures with upward
growing stacks.

-apw