Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264763AbTFLGr4 (ORCPT ); Thu, 12 Jun 2003 02:47:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264765AbTFLGqx (ORCPT ); Thu, 12 Jun 2003 02:46:53 -0400 Received: from e34.co.us.ibm.com ([32.97.110.132]:14258 "EHLO e34.co.us.ibm.com") by vger.kernel.org with ESMTP id S264763AbTFLGqO (ORCPT ); Thu, 12 Jun 2003 02:46:14 -0400 Date: Thu, 12 Jun 2003 12:36:15 +0530 From: Ravikiran G Thirumalai To: Andrew Morton Cc: linux-kernel@vger.kernel.org Subject: Re: [patchset] Fix sign handling bugs in 2.5 -- 2/5; epca Message-ID: <20030612070613.GC1146@llm08.in.ibm.com> References: <20030612070330.GA1146@llm08.in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030612070330.GA1146@llm08.in.ibm.com> User-Agent: Mutt/1.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 928 Lines: 26 --- linux-2.5.70/drivers/char/epca.c Tue May 27 06:30:41 2003 +++ shb-epca-2.5.70/drivers/char/epca.c Wed Jun 11 16:09:43 2003 @@ -3740,7 +3740,7 @@ case 5: board.port = (unsigned char *)ints[index]; - if (board.port <= 0) + if (ints[index] <= 0) { printk(KERN_ERR " - epca_setup: Invalid io port 0x%x\n", (unsigned int)board.port); invalid_lilo_config = 1; @@ -3752,7 +3752,7 @@ case 6: board.membase = (unsigned char *)ints[index]; - if (board.membase <= 0) + if (ints[index] <= 0) { printk(KERN_ERR " - epca_setup: Invalid memory base 0x%x\n",(unsigned int)board.membase); invalid_lilo_config = 1; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/