Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752705AbdFTJKr (ORCPT ); Tue, 20 Jun 2017 05:10:47 -0400 Received: from mail-io0-f178.google.com ([209.85.223.178]:33337 "EHLO mail-io0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752187AbdFTJKn (ORCPT ); Tue, 20 Jun 2017 05:10:43 -0400 MIME-Version: 1.0 In-Reply-To: <20170612060718.GA8566@spreadtrum.com> References: <359d62c1f2f7ef61c6160df9b60c1af4bfcea89a.1496664241.git.baolin.wang@spreadtrum.com> <20170612060718.GA8566@spreadtrum.com> From: Linus Walleij Date: Tue, 20 Jun 2017 11:10:41 +0200 Message-ID: Subject: Re: [PATCH v2 1/2] DT: pinctrl: Add binding documentation for Spreadtrum pin controller To: Linus Walleij , Mark Rutland , Rob Herring , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Mark Brown , Baolin Wang Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 677 Lines: 20 On Mon, Jun 12, 2017 at 8:07 AM, Baolin Wang wrote: > I agree we should add these into core code, something like: > static const struct pinconf_generic_params dt_params[] = { (...) > { "slew-rate", PIN_CONFIG_SLEW_RATE, 0 }, > + { "sleep-bias-pull-up", PIN_CONFIG_SLEEP_BIAS_PULL_UP, 1}, > + { "sleep-bias-pull-down", PIN_CONFIG_SLEEP_BIAS_PULL_DOWN 1}, > ...... > }; > > If you agree that, I can help to add these configuration. Actually, yes indeed, that is a nice thing. Very nice. I think my Nomadik driver could use this too. Just need to hear what the DT maintainers have to say about it. Yours, Linus Walleij